Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOBBLIN-2160] Setup Temporal docker Cluster for CI Tests and added tests for AbstractNestingExecWorkflowImpl #4059

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[GOBBLIN-2160] Setup Temporal docker Cluster for CI Tests and added tests for AbstractNestingExecWorkflowImpl #4059

wants to merge 7 commits into from

Conversation

pratapaditya04
Copy link
Contributor

@pratapaditya04 pratapaditya04 commented Sep 24, 2024 •
edited
Loading

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    Added Unit tests for JobStateUtils and AbstractNestingExecWorkflowImpl classes in Gobblin-temporal module

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@pratapaditya04 pratapaditya04 changed the title [GOBBLIN-2160] added some unit tests for gobblin temporal module [GOBBLIN-2160] Setup Temporal docker Cluster for CI Tests and added tests for AbstractNestingExecWorkflowImpl Oct 8, 2024
Blazer-007
Blazer-007 reviewed Nov 12, 2024
View reviewed changes
.../java/org/apache/gobblin/temporal/ddm/workflow/impl/AbstractNestingExecWorkflowImplTest.java
Comment on lines +52 to +54

private static final Logger logger = LoggerFactory.getLogger(AbstractNestingExecWorkflowImplTest.class);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to log / or print something in tests, can we please remove them ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blazer-007 Blazer-007 Blazer-007 left review comments

@khandelwal-prateek khandelwal-prateek khandelwal-prateek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pratapaditya04 @Blazer-007 @khandelwal-prateek